Hi George,
Le 18/10/2025 à 08:07, george chan a écrit :
Dear Guillaume,
Thx for your patch.
在 2025年10月17日週五 21:19，Guillaume La Roque (TI.com)
<[email protected]> 寫道：
This patchset add support of android bootconfig partition[1] in
u-boot.
With Android boot image v4, all androidboot.* arguments must be
passed via bootconfig instead of using the kernel commandline.
it looks like the above add logic handled bootargs well.
is this logic support the use case of appending existing bootargs from
env and handle the one mentioned in
[1] for simulation of vendor bootloader behavior to append some
androidboot.* bootcmd to formulate a new bootargs? Or is this series
complementary to [1] so as aimed to "move" androidboot.* only to
bootconfig? If this [1] user case is covered then I am very happy to
stop [1] if this series can have same result.
Btw, I am wondering if this series assumed Androidboot v4 only, so
kernel ver must >= 5.4 and enabled with bootconfig. Since then
bootconfig can be unlimited to it's length. So all predefined
androidboot.* from bootloader, can now move out, and no need of
default bootargs in env file any more.
And how about those Androidboot v2 case?
[1] https://lists.denx.de/pipermail/u-boot/2025-October/599708.html
in TI project we have this patch
https://git.ti.com/cgit/ti-u-boot/ti-u-boot/commit/?h=ti-u-boot-2024.04-next&id=9d802d798ac143e06ffe545606aa657a6c32cc63
, we forgot to upstream it but i'll plan to do it if it's not a problem
for you. let me know if it's ok for you and i send it this week. Normaly
this patch resolve your issue, it's not mandatory for bootconfig support
but needed to not lost all other bootargs no link to android in bootargs
when you use bootmeth_android.
Except if i do some error in code, boot config code was only do when you
have android image version 4, code take all androidboot.* param in
bootarg, remove it in booatarg and put it in bootconfig partition before
booting android.
some arg was adding in bootargs in bootargs automatically(serial, avb
arg, slot etc etc) so instead of check where it's done version of
android boot image we have we prefer to do it just before booting.
for fastboot boot i never test it with TI board.
Guillaume
Regards
George
[1]
https://source.android.com/docs/core/architecture/bootloader/implementing-bootconfig
Signed-off-by: Guillaume La Roque (TI.com) <[email protected]>
---
Changes in v2:
- Add test
- Add new command to be able to load and read bootconfig before
booting
- Somes fixes to works with sandbox test
- Link to v1:
https://lore.kernel.org/all/[email protected]/
---
Guillaume La Roque (TI.com) (4):
boot: android: Add sandbox memory mapping support
boot: android: Add bootconfig support
cmd: abootimg: Add 'get ramdisk' command
test: abootimg: Add test for bootconfig handling
Mattijs Korpershoek (TI.com) (1):
boot: android: import addBootConfigParameters() from AOSP
boot/image-android.c | 180
++++++++++++++++++++++++----
cmd/abootimg.c | 35 +++++-
test/py/tests/test_android/test_abootimg.py | 108 +++++++++++++++--
3 files changed, 292 insertions(+), 31 deletions(-)
---
base-commit: 2ba64e303b2706e5c42a6bf982326d632342ca66
change-id: 20241128-bootconfig-276e247be992
Best regards,
--
Guillaume La Roque (TI.com) <[email protected]>
