On 10/28/25 9:17 AM, Neil Armstrong wrote:

Hello Neil,

+static int ufs_renesas_pre_init(struct ufs_hba *hba)
+{
+    struct ufs_renesas_priv *priv = dev_get_priv(hba->dev);
+    u32 val32;
+    u16 val16;
+    int ret;
+
+    writew(0x0001, priv->phy_base + 0x20000);

The driver looks good, but it's a shame there's not a single
register or field define to use instead of magic numbers !
I'm sorry about that, the init procedure comes from the hardware team.

Reply via email to