On 11/14/25 11:55, Maarten Brock wrote:
Hello Heinrich,
Don't you run the risk of getting into namespace problems when you make these
static functions and global variables non-static? Esp. the ones without the word
'fat' in them seem to be in danger here.
E.g. downcase(), cur_dev, disk_read()
Kind Regards,
Maarten
Thank you for reviewing. You are right. These functions should be
renamed with a "fat_" prefix.
Best regards
Heinrich
-----Original Message-----
From: U-Boot<[email protected]> On Behalf Of Heinrich Schuchardt
Sent: Thursday, 13 November 2025 07:47
To: Tom Rini<[email protected]>
Cc: Simon Glass<[email protected]>; Gabriel Dalimonte
<[email protected]>; AKASHI Takahiro<[email protected]>; u-
[email protected]; Claude<[email protected]>; Heinrich Schuchardt
<[email protected]>
Subject: [PATCH 2/6] fat: Separate fat.c from fat_write.c
From: Simon Glass<[email protected]>
Currently fat_write.c includes fat.c directly, which is unusual and
makes the code harder to maintain. Use the internal header file to hold
shared functions, to avoid this.
Co-developed-by: Claude<[email protected]>
Signed-off-by: Simon Glass<[email protected]>
Tested-by: Heinrich Schuchardt<[email protected]>
