On Mon, 22 Dec 2025 at 13:41, Heinrich Schuchardt < [email protected]> wrote:
> On 12/22/25 09:17, Ilias Apalodimas wrote: > > Hi Heinrich, > > > > On Sat, 20 Dec 2025 at 00:43, Heinrich Schuchardt > > <[email protected] > > <mailto:[email protected]>> wrote: > > > > We cannot build the LMB test without the LMB library. > > > > > > This was always building LMB. do we need to adjust any Kconfigs with > > this change? > > We should be able to enable CONFIG_UNIT_TEST on any board. > > Many boards use CONFIG_LMB=y but not all, e.g. > amd_versal2_mini_defconfig. Building this board with CONFIG_UNIT_TEST=y > fails: > > aarch64-linux-gnu-ld: > test/lib/lmb.c:411:(.text.test_noreserved+0x428): > undefined reference to `lmb_free' > > With this patch on top there is no build issue. > Ok, please update the commit message when merging Reviewed-by: Ilias Apalodimas <[email protected]> > > Best regards > > Heinrich > > > > > > > Signed-off-by: Heinrich Schuchardt > > <[email protected] > > <mailto:[email protected]>> > > --- > > test/lib/Makefile | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/test/lib/Makefile b/test/lib/Makefile > > index 7c9dc180c8d..f25383a40e5 100644 > > --- a/test/lib/Makefile > > +++ b/test/lib/Makefile > > @@ -16,7 +16,7 @@ obj-$(CONFIG_USE_PRIVATE_LIBGCC) += test_ctz.o > > endif > > obj-y += hexdump.o > > obj-$(CONFIG_SANDBOX) += kconfig.o > > -obj-y += lmb.o > > +obj-$(CONFIG_LMB) += lmb.o > > obj-$(CONFIG_HAVE_SETJMP) += longjmp.o > > obj-$(CONFIG_SANDBOX) += membuf.o > > obj-$(CONFIG_HAVE_INITJMP) += initjmp.o > > -- > > 2.51.0 > > > >
