On 1/2/26 17:21, Marek Vasut wrote:
On 1/2/26 4:15 PM, Heinrich Schuchardt wrote:
[...]
Looking at https://gitlab.com/CalcProgrammer1/OpenRGB/ the protocols
used to control keyboard backlights vary a lot between vendors.
openrgb seems to be meant to control various fancy vendor LEDs and such,
I'm talking about the boring 1-color keyboard backlight on laptop
keyboards.
But anyway the vendor ID and product ID is used to identify the USB
keyboard and to look up which protocol it uses. There is no need for a
device-tree description.
It is in fact the other way around -- if it is a HID keyboard device
according to USB descriptor, it doesn't matter which VID/PID it has. The
few keyboards described in the usb_kbd.c driver are there because they
need quirks.
I wrote about backlight drivers needing VID/PID in OpenRGB for discovery
of the protocol.
So, to move the discussion along. I can see why an USB keyboard might
have to be described in DT. It seems the usb-keyboard DT compatible is
not standard. If it should be removed, the commit message needs much
better justification for doing so.
I can't see any use case for a USB keyboard described by a fantasy
compatible string which no operating system supports.
Leaving this unused code is just a waste of binary size.
I have updated the commit message in v2.
Best regards
Heinrich
