Hi Heinrich, On Fri, Jan 02, 2026 at 09:40:39AM +0100, Heinrich Schuchardt wrote: > On 1/2/26 09:29, Heinrich Schuchardt wrote: > > On 1/1/26 18:54, Kuan-Wei Chiu wrote: > > > Add support for the Google Goldfish TTY serial device. This virtual > > > device is commonly used in QEMU virtual machines (such as the m68k > > > virt machine) and Android emulators. > > > > > > The driver implements basic console output and input polling using the > > > Goldfish MMIO interface. > > > > > > Signed-off-by: Kuan-Wei Chiu <[email protected]> > > > Reviewed-by: Yao Zi <[email protected]> > > > Tested-by: Daniel Palmer <[email protected]> > > > > Acked-by: Heinrich Schuchardt <[email protected]>
Thanks for the review. > > > > > --- > > > Changes in v4: > > > - Support DT probing with platform data as a fallback. > > > > > > MAINTAINERS | 6 ++ > > > drivers/serial/Kconfig | 8 +++ > > > drivers/serial/Makefile | 1 + > > > drivers/serial/serial_goldfish.c | 109 +++++++++++++++++++++++++++++++ > > > include/goldfish_tty.h | 18 +++++ > > > 5 files changed, 142 insertions(+) > > > create mode 100644 drivers/serial/serial_goldfish.c > > > create mode 100644 include/goldfish_tty.h > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > index 6ce0bbce13d..da4a6e4d518 100644 > > > --- a/MAINTAINERS > > > +++ b/MAINTAINERS > > > @@ -1259,6 +1259,12 @@ S: Maintained > > > F: drivers/misc/gsc.c > > > F: include/gsc.h > > > +GOLDFISH SERIAL DRIVER > > > +M: Kuan-Wei Chiu <[email protected]> > > > +S: Maintained > > > +F: drivers/serial/serial_goldfish.c > > > +F: include/goldfish_tty.h > > > + > > Applying: serial: Add Goldfish TTY driver > Patch failed at 0001 serial: Add Goldfish TTY driver > error: patch failed: MAINTAINERS:1259 > error: MAINTAINERS: patch does not apply > > Should a respin of the series be needed, please, check that the series > applies to origin/next before sending. To make sure I base the next version on the correct tree, should I base it on the ColdFire tree's next branch: https://source.denx.de/u-boot/custodians/u-boot-coldfire.git Or the main U-Boot repository's next branch: https://source.denx.de/u-boot/u-boot.git Regards, Kuan-Wei
