Hi Jonas,

Thank you very much for your work!

On 1/8/26 08:07, Jonas Karlman wrote:
This series add initial support for RK3582 support. The RK3582 is a
variant of the RK3588S with a few ip blocks disabled. What blocks are
disabled/non-working is indicated by the ip-state in OTP.

Compared to the vendor U-Boot variant, this mark cpu, the gpu and
vdec/venc with status=fail instead of removing nodes during DT fixup.
Linux skip cpu cores marked as failed staring from v5.17-rc1, however
the GIC driver will generate a harmless WARN_ON that safely can be
ignored. A patch for Linux will be sent to skip the WARN_ON for
failed/disabled cpu cores once this lands.

It is recommended to use rk3588_ddr_lp4_1848MHz_lp5_2112MHz_v1.19.bin
as DRAM init blob RK3582, listed in latest RKBOOT/RK3582MINIALL.ini.

Changes in v4:
- Update policy to always fail gpu for RK3582
- Drop code and comment related to RK3583
- Update rkvdec node name to match latest mainline Linux DT patches
- Update commit message to reflect updated policy

Changes in v3:
- Apply same policy for RK3582/RK3583 to match vendor U-Boot
   linux-6.1-stan-rkr6 tag, allow use of the GPU and one vdec core.
- Update rkvdec node name to match latest mainline Linux DT patches.
- Update commit message to reflect updated policy

Changes in v2:
- Refactor code to first apply policy to ip-state and then fail cores
   based on the updated ip-state
- Add support for failing rkvdec and rkvenc cores
- Append soc compatible to board model
- Add patch to add support for ROCK 5C Lite variant

Jonas Karlman (3):
   rockchip: Add initial RK3582 support
   rockchip: rk3588-generic: Enable support for RK3582
   rockchip: rk3588s-rock-5c: Add support for ROCK 5C Lite variant

  arch/arm/dts/rk3588-generic.dts        |   4 +-
  arch/arm/mach-rockchip/rk3588/Kconfig  |   9 +-
  arch/arm/mach-rockchip/rk3588/rk3588.c | 215 +++++++++++++++++++++++++
  configs/generic-rk3588_defconfig       |   1 +
  configs/rock-5c-rk3588s_defconfig      |   1 +
  doc/board/rockchip/rockchip.rst        |   4 +-
  6 files changed, 226 insertions(+), 8 deletions(-)

Tested on Radxa E52C:

cpu-code: 35 82
ip-state: 00 04 00 (otp)
ip-state: c0 9e 04 (policy)
remove cpu-map cluster2
fail gpu
fail rkvdec1
fail rkvenc1
fail cpu cpu@600
fail cpu cpu@700

and on Radxa ROCK 5C Lite:

cpu-code: 35 82
ip-state: 10 00 00 (otp)
ip-state: 30 9e 04 (policy)
remove cpu-map cluster1
rename cpu-map cluster2
fail gpu
fail rkvdec1
fail rkvenc1
fail cpu cpu@400
fail cpu cpu@500


For the whole series,

Tested-by: FUKAUMI Naoki <[email protected]>

Best regards,

--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.

Reply via email to