On Wed, Jan 14, 2026 at 06:29:55PM +0100, Quentin Schulz wrote: > Hi Aswin, > > On 1/7/26 4:47 PM, Aswin Murugan wrote: > > Introduce a new Kconfig option PINCTRL_QCOM_GENERIC that, when selected, > > enables all Qualcomm pinctrl drivers by default. This simplifies defconfigs > > for platforms supporting multiple SoCs and avoids manual driver selection. > > Individual drivers can still be disabled if required. > > > > Signed-off-by: Aswin Murugan <[email protected]> > > --- > > Changes in v2: > > - As per review comments made default y for pinctrl drivers > > based on PINCTRL_QCOM_GENERIC config 'default y if PINCTRL_QCOM_GENERIC' > > ---
"---" is redundant here and may be causing issues with the b4 patch pickup. > > drivers/pinctrl/qcom/Kconfig | 29 +++++++++++++++++++++++++++++ > > 1 file changed, 29 insertions(+) > > > > diff --git a/drivers/pinctrl/qcom/Kconfig b/drivers/pinctrl/qcom/Kconfig > > index 725200d94c8..580308621b1 100644 > > --- a/drivers/pinctrl/qcom/Kconfig > > +++ b/drivers/pinctrl/qcom/Kconfig > > @@ -6,8 +6,17 @@ config PINCTRL_QCOM > > menu "Qualcomm pinctrl drivers" > > +config PINCTRL_QCOM_GENERIC > > + bool "Enable all Qualcomm pinctrl drivers by default" > > + select PINCTRL_QCOM > > + help > > + Say Y here to enable all Qualcomm pinctrl drivers by default. > > + This is useful for generic Qualcomm defconfigs that support > > + multiple SoCs. Individual drivers can still be disabled if needed. > > + > > config PINCTRL_QCOM_APQ8016 > > bool "Qualcomm APQ8016 Pinctrl" > > + default y if PINCTRL_QCOM_GENERIC > > select PINCTRL_QCOM > > help > > Say Y here to enable support for pinctrl on the MSM8916 / APQ8016 > > @@ -15,6 +24,7 @@ config PINCTRL_QCOM_APQ8016 > > config PINCTRL_QCOM_APQ8096 > > bool "Qualcomm APQ8096 Pinctrl" > > + default y if PINCTRL_QCOM_GENERIC > > select PINCTRL_QCOM > > help > > Say Y here to enable support for pinctrl on the MSM8996 / APQ8096 > > @@ -22,6 +32,7 @@ config PINCTRL_QCOM_APQ8096 > > config PINCTRL_QCOM_IPQ4019 > > bool "Qualcomm IPQ4019 Pinctrl" > > + default y if PINCTRL_QCOM_GENERIC > > select PINCTRL_QCOM > > help > > Say Y here to enable support for pinctrl on the IPQ4019 SoC, > > @@ -29,6 +40,7 @@ config PINCTRL_QCOM_IPQ4019 > > config PINCTRL_QCOM_IPQ5424 > > bool "Qualcomm IPQ5424 Pinctrl" > > + default y if PINCTRL_QCOM_GENERIC > > select PINCTRL_QCOM > > help > > Say Y here to enable support for pinctrl on the IPQ5424 SoC, > > @@ -36,6 +48,7 @@ config PINCTRL_QCOM_IPQ5424 > > config PINCTRL_QCOM_IPQ9574 > > bool "Qualcomm IPQ9574 Pinctrl" > > + default y if PINCTRL_QCOM_GENERIC > > select PINCTRL_QCOM > > help > > Say Y here to enable support for pinctrl on the IPQ9574 SoC, > > @@ -43,6 +56,7 @@ config PINCTRL_QCOM_IPQ9574 > > config PINCTRL_QCOM_QCM2290 > > bool "Qualcomm QCM2290 Pinctrl" > > + default y if PINCTRL_QCOM_GENERIC > > select PINCTRL_QCOM > > help > > Say Y here to enable support for pinctrl on the Snapdragon QCM2290 > > SoC, > > @@ -50,6 +64,7 @@ config PINCTRL_QCOM_QCM2290 > > config PINCTRL_QCOM_QCS404 > > bool "Qualcomm QCS404 Pinctrl" > > + default y if PINCTRL_QCOM_GENERIC > > select PINCTRL_QCOM > > help > > Say Y here to enable support for pinctrl on the Snapdragon QCS404 SoC, > > @@ -57,6 +72,7 @@ config PINCTRL_QCOM_QCS404 > > config PINCTRL_QCOM_QCS615 > > bool "Qualcomm QCS615 Pinctrl" > > + default y if PINCTRL_QCOM_GENERIC > > Indentation seems incorrect here? With indentation fixed, feel free to add: Reviewed-by: Sumit Garg <[email protected]> -Sumit > > b4 doesn't want to pick up the patch from lore so cannot check if it's an > actual problem or not. See: > > $ b4 shazam --add-my-sob --add-link > https://lore.kernel.org/u-boot/[email protected]/ > [...] > Applying: pinctrl: qcom: add PINCTRL_QCOM_GENERIC to enable all drivers by > default > Patch failed at 0001 pinctrl: qcom: add PINCTRL_QCOM_GENERIC to enable all > drivers by default > error: sha1 information is lacking or useless > (drivers/pinctrl/qcom/Kconfig). > error: could not build fake ancestor > [...] > > Cheers, > Quentin
