Hi Wojciech,

On 1/20/26 9:12 AM, Wojciech Dubowik wrote:
Only short option has been present.


Actually.... it's been there, just under dump-sig and not dump_sig.

So we have the choice of either fixing the usage string and the manpage to use dump-sig instead of dump_sig or support both.

I would personally be in favor of patching the usage string and manpage so we don't have long options with an underscore.. it's odd to me.

Regardless of your choice, we need

Fixes: 16abff246b40 ("tools: mkeficapsule: add firmware image signing")

in the commit log.

If you keep dump_sig, I would really recommend to put it next to dump-sig and explain why we have both (we need to keep dump-sig for free backward compatibility).

Cheers,
Quentin

Reply via email to