Dear Becky Bruce,
In message <13107687401917-git-send-email-bec...@kernel.crashing.org> you wrote:
> The way I wrote this in the first time was based on the original
> code, but I used a karnaugh map to make it a bit easier to
> read..... There should be no functional change.
Ummm...
> #if defined(CONFIG_TQM_BIGFLASH) || \
> - (!defined(CONFIG_TQM8548_AG) && !defined(CONFIG_TQM8548_BE))
> + defined(CONFIG_TQM8548_AG) || \
> + defined(CONFIG_TQM8548_BE)
Sorry, but this looks wrong to me.
Isn't the rule "foo & bar == !(!foo || !bar)", so that
(!defined(CONFIG_TQM8548_AG) && !defined(CONFIG_TQM8548_BE))
becomes
!(defined(CONFIG_TQM8548_AG) || defined(CONFIG_TQM8548_BE))
?
I think you are missing the "not" part...
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Heavier than air flying machines are impossible.
-- Lord Kelvin, President, Royal Society, c. 1895
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
