I understand, Tom, I'm just asking Peng Fan if this won't break his build,
as he mentioned earlier.

And please, Tom and Peng Fan, forgive me if I made any mistakes in the
patch submission procedure, it's my first contribution to the project and I
truly admire you for maintaining such a large project.

I hope to learn from you and contribute more to the community.

BR,
Mateus

On Wed, Jan 28, 2026 at 5:21 PM Tom Rini <[email protected]> wrote:

> On Wed, Jan 28, 2026 at 05:02:47PM -0300, Mateus Lima wrote:
>
> > Hi Tom,
> >
> > Indeed, there are a lot of PPC targets that try to use this symbol, but
> as
> > Peng Fan reported before, his CI reported a build failure.
>
> Yes, I'm not sure what the particular problem there was with your
> previous patch / Peng's setup:
> https://source.denx.de/u-boot/u-boot/-/pipelines/29116
> (the failure is because we need
> https://patchwork.ozlabs.org/project/uboot/list/?series=488348&state=*
> merged to master).
>
> >
> > On Wed, Jan 21, 2026 at 11:13 PM Peng Fan <[email protected]> wrote:
> >
> > > On Tue, Jan 13, 2026 at 11:23:01AM -0300, Mateus Lima Alves wrote:
> > > >This patch adds CPLD support via IFC to the ls1021a-iot board.
> > > >
> > > >Signed-off-by: Mateus Lima Alves <[email protected]>
> > >
> > > CI report build failure.
> > >
> > >   CC      drivers/video/hitachi-tx10d07vm0baa.o
> > > In file included from drivers/misc/fsl_ifc.c:8:
> > > include/fsl_ifc.h:16:10: fatal error: asm/ppc.h: No such file or
> directory
> > >    16 | #include <asm/ppc.h>
> > >       |          ^~~~~~~~~~~
> > > compilation terminated.
> > > make[3]: *** [scripts/Makefile.build:271: drivers/misc/fsl_ifc.o]
> Error 1
> > > make[2]: *** [scripts/Makefile.build:492: drivers/misc] Error 2
> > > make[2]: *** Waiting for unfinished jobs....
> > >   CC      drivers/rtc/ht1380.o
> > >   CC      drivers/video/hitachi_tx18d42vm_lcd.o
> > >   CC      drivers/rtc/i2c_rtc_emul.o
> > >
> > > make[1]: *** [Makefile:2191: drivers] Error 2
> > > make: *** [Makefile:362: __build_one_by_one] Error 2
> > > Cleaning up project directory and file based variables
> > >
> > > Regards
> > > Peng
> >
> >
> > Is that okay now Peng Fan?
> >
> > If so, then my v2 patch would have worked.
> >
> > BR,
> > Mateus
> >
> > On Wed, Jan 28, 2026 at 4:26 PM Tom Rini <[email protected]> wrote:
> >
> > > This symbol is used on a number of PowerPC platforms as well, so make
> it
> > > available there again.
> > >
> > > Fixes: 424b324165ea ("armv7: Add CPLD support via IFC to the
> ls1021a-iot
> > > board.")
> > > Signed-off-by: Tom Rini <[email protected]>
> > > ---
> > > Cc: Mateus Lima Alves <[email protected]>
> > > Cc: Peng Fan <[email protected]>
> > > ---
> > >  drivers/misc/Kconfig | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> > > index be7fdab56d14..a0aa290480eb 100644
> > > --- a/drivers/misc/Kconfig
> > > +++ b/drivers/misc/Kconfig
> > > @@ -695,7 +695,7 @@ config ESM_PMIC
> > >
> > >  config FSL_IFC
> > >         bool "Freescale Integrated Flash Controller"
> > > -       depends on ARM
> > > +       depends on ARM || PPC
> > >         help
> > >           This driver is for the Integrated Flash Controller(IFC)
> module
> > >           available in Freescale SoCs. This controller allows to handle
> > > --
> > > 2.43.0
> > >
> > >
>
> --
> Tom
>

Reply via email to