Hi Ilias, On 11.02.26 16:25, Ilias Apalodimas wrote: > Hi Frieder > > On Wed, 11 Feb 2026 at 15:35, Frieder Schrempf > <[email protected]> wrote: >> >> On 16.12.25 10:16, Ilias Apalodimas wrote: >>> From: Sughosh Ganu <[email protected]> >>> >>> Our last sync with the kernel was 5.1. >>> >>> We are so out of sync now, that tracking the patches and backporting >>> them one by one makes little sense and it's going to take ages. >>> >>> This is an attempt to sync up Makefiles to 6.1. >>> Unfortunately due to sheer amount of patches this is not easy to review, >>> but that's what we decided during a community call for the bump to 5.1, >>> so we are following the same guidelines here. >>> >>> Signed-off-by: Sughosh Ganu <[email protected]> >>> Signed-off-by: Ilias Apalodimas <[email protected]>a #rebased on >>> -next >> >> To me, it looks like this is breaking "make cross_tools" in some way. Or >> am I missing something? >> >> With v2026.04-rc2: >> >>> make tools-only_defconfig >>> make cross_tools >> UPD include/generated/timestamp_autogenerated.h >> PYMOD rebuild >> tools/Makefile:359: *** insufficient number of arguments (1) to function >> 'filter'. Stop. >> make: *** [Makefile:2191: tools] Error 2 > > Does the below fix it ?
Yes it does! Thanks Frieder > diff --git a/tools/Makefile b/tools/Makefile > index 0ac683ac3ec7..c4308304d99a 100644 > --- a/tools/Makefile > +++ b/tools/Makefile > @@ -356,9 +356,9 @@ override HOSTCFLAGS = $(CFLAGS) > > quiet_cmd_crosstools_strip = STRIP $^ > cmd_crosstools_strip = $(STRIP) $^; touch $@ > -$(obj)/.strip: $(call objectify,$(filter $(hostprogs-always-y))) > +$(obj)/.strip: $(call objectify,$(filter $(always),$(hostprogs-y))) > $(call cmd,crosstools_strip) > > -always-y += .strip > +always += .strip > endif > clean-files += .strip > > Thanks > /Ilias >> >> If the problem is not on my end, then I would have assumed the CI would >> be able to catch it. But "make cross_tools" is not part of any test, right? >> >> Best regards >> Frieder
