On Thu, Feb 19, 2026 at 07:31:17AM -0700, Simon Glass wrote: > Hi Tom, > > On Thu, 19 Feb 2026 at 07:00, Tom Rini <[email protected]> wrote: > > > > On Thu, Feb 19, 2026 at 06:09:28AM -0700, Simon Glass wrote: > > > On Mon, 16 Feb 2026 at 14:23, Daniel Golle <[email protected]> wrote: > > > > > > > > Add the initial bootmeth_openwrt driver with: > > > > > > > > - UCLASS_BOOTMETH driver, compatible "u-boot,openwrt" > > > > - check(): accept block devices via bootflow_iter_check_blk() > > > > - bind(): set BOOTMETHF_ANY_PART so bootstd iterates all partitions > > > > without requiring a filesystem > > > > - read_bootflow(): stub returning -ENOENT > > > > - boot(): stub returning -ENOSYS > > > > - Kconfig: CONFIG_BOOTMETH_OPENWRT depending on FIT, BOOTSTD, > > > > BOOTM_STORAGE > > > > > > We don't normally write out this much detail in the code > > > > I assume you mean the commit message? And yes, this reads like an > > AI genreated (then human proof-read) commit message. Which is something > > I wanted to address, once done with the open questions I still have in > > the cover letter. > > Yes I meant 'about' the code not 'in' the code. > > You can normally fix it by asking for prose, or giving it some general > instructions.
If that's even a good idea, sure. Some of the policies I was reading yesterday disallow having the AI generate the commit message because the human should be able to read and understand and explain the code. -- Tom
signature.asc
Description: PGP signature
