Hi David, Thanks for your patch!
On Fri, Feb 06, 2026 at 02:50:06PM -0600, David Lechner wrote: >Add support for MediaTek MT8189 MMC controller. > >According to [1], this is similar to, but not quite the same as >mediatek,mt8196-mmc. > >Link: >https://lore.kernel.org/linux-mediatek/[email protected]/ > [1] >Signed-off-by: David Lechner <[email protected]> >--- > drivers/mmc/mtk-sd.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > >diff --git a/drivers/mmc/mtk-sd.c b/drivers/mmc/mtk-sd.c >index 4928a880038..7a4bdee7496 100644 >--- a/drivers/mmc/mtk-sd.c >+++ b/drivers/mmc/mtk-sd.c >@@ -1979,6 +1979,16 @@ static const struct msdc_compatible mt8183_compat = { > .use_dma_mode = true, > }; > >+static const struct msdc_compatible mt8189_compat = { >+ .clk_div_bits = 12, >+ .pad_tune0 = true, >+ .async_fifo = true, >+ .data_tune = true, >+ .busy_check = true, >+ .stop_clk_fix = true, >+ .enhance_rx = true, >+}; >+ > static const struct udevice_id msdc_ids[] = { > { .compatible = "mediatek,mt7620-mmc", .data = (ulong)&mt7620_compat }, > { .compatible = "mediatek,mt7621-mmc", .data = (ulong)&mt7621_compat }, >@@ -1990,6 +2000,7 @@ static const struct udevice_id msdc_ids[] = { > { .compatible = "mediatek,mt8512-mmc", .data = (ulong)&mt8512_compat }, > { .compatible = "mediatek,mt8516-mmc", .data = (ulong)&mt8516_compat }, > { .compatible = "mediatek,mt8183-mmc", .data = (ulong)&mt8183_compat }, >+ { .compatible = "mediatek,mt8189-mmc", .data = (ulong)&mt8189_compat }, I not see this compatible being in dts/upstream or arch/arm/dts/, so has this patch been tested with upstream U-Boot? Thanks Peng > {} > }; > > >--- >base-commit: e5e75ea8c7b8e6d9ce1ca8ec7a25fa8b3f6029a9 >change-id: 20260206-mtk-mmc-add-mt8189-compatible-6a71d5c710dc > >Best regards, >-- >David Lechner <[email protected]> > >
