On 2/23/26 21:28, Andrew Davis wrote:
> On 2/23/26 3:13 AM, Shiva Tripathi wrote:
>> Enable firmware TPM (fTPM) support for AM62x, AM62Ax, and AM62Px SoCs
>> by adding OP-TEE and TPM configuration options to the A53 defconfigs.
>>
>> The AM62 family SoCs do not include an integrated hardware TPM. This
> 
> No K3 SoC integrates a full TPM, so why do this only for AM62? And
> why only the TI EVMs? *All* K3 SoCs and *all* boards based on them
> can make use of OP-TEE's fTPM, so why not move this to a common location
> in the Kconfig files. That way you don't need to add all this in every
> single defconfig.
> 
> For instance the CONFIG_CMD_* ones can be added to TI_COMMON_CMD_OPTIONS,
> 
> config TI_COMMON_CMD_OPTIONS
>     imply CMD_MMC_RPMB if SUPPORT_EMMC_RPMB
> etc..
> 
> Andrew

Thanks for the review. Yes fTPM can be enabled for all K3 SoCs.
I will send an updated version of the patch with suggested changes.

Regards,
Shiva

> 
>> patch enables the Microsoft fTPM Trusted Application running in OP-TEE's
>> secure world to provide TPM 2.0 functionality, with persistent storage
>> backed by the eMMC RPMB partition.
>>
>> This enables TPM 2.0 functionality in U-Boot and provides the foundation
>> for measured boot and disk encryption use cases.
>>
>> Signed-off-by: Shiva Tripathi <[email protected]>
>> ---
>>   configs/am62ax_evm_a53_defconfig | 9 +++++++++
>>   configs/am62px_evm_a53_defconfig | 9 +++++++++
>>   configs/am62x_evm_a53_defconfig  | 9 +++++++++
>>   3 files changed, 27 insertions(+)
>>
>> diff --git a/configs/am62ax_evm_a53_defconfig b/configs/
>> am62ax_evm_a53_defconfig
>> index 167ba7ff8df..b14f19968a3 100644
>> --- a/configs/am62ax_evm_a53_defconfig
>> +++ b/configs/am62ax_evm_a53_defconfig
>> @@ -99,5 +99,14 @@ CONFIG_SYSRESET=y
>>   CONFIG_SPL_SYSRESET=y
>>   CONFIG_SYSRESET_TI_SCI=y
>>   CONFIG_FS_FAT_MAX_CLUSTSIZE=16384
>> +CONFIG_TEE=y
>> +CONFIG_OPTEE=y
>> +CONFIG_TPM=y
>> +CONFIG_TPM_V2=y
>> +CONFIG_CMD_TPM=y
>> +CONFIG_TPM2_FTPM_TEE=y
>> +CONFIG_CMD_OPTEE_RPMB=y
>> +CONFIG_SUPPORT_EMMC_RPMB=y
>> +CONFIG_CMD_MMC_RPMB=y
>>     #include <configs/am62x_a53_usbdfu.config>
>> diff --git a/configs/am62px_evm_a53_defconfig b/configs/
>> am62px_evm_a53_defconfig
>> index aa241a73c3f..2cd572cd5c7 100644
>> --- a/configs/am62px_evm_a53_defconfig
>> +++ b/configs/am62px_evm_a53_defconfig
>> @@ -148,6 +148,15 @@ CONFIG_SPL_USB_HOST=y
>>   CONFIG_SPL_USB_STORAGE=y
>>   CONFIG_FS_FAT_MAX_CLUSTSIZE=16384
>>   CONFIG_EFI_SET_TIME=y
>> +CONFIG_TEE=y
>> +CONFIG_OPTEE=y
>> +CONFIG_TPM=y
>> +CONFIG_TPM_V2=y
>> +CONFIG_CMD_TPM=y
>> +CONFIG_TPM2_FTPM_TEE=y
>> +CONFIG_CMD_OPTEE_RPMB=y
>> +CONFIG_SUPPORT_EMMC_RPMB=y
>> +CONFIG_CMD_MMC_RPMB=y
>>     #include <configs/k3_efi_capsule.config>
>>   #include <configs/am62x_a53_usbdfu.config>
>> diff --git a/configs/am62x_evm_a53_defconfig b/configs/
>> am62x_evm_a53_defconfig
>> index 281fa3fea15..3221a9b8f2b 100644
>> --- a/configs/am62x_evm_a53_defconfig
>> +++ b/configs/am62x_evm_a53_defconfig
>> @@ -138,6 +138,15 @@ CONFIG_SPL_SYSRESET=y
>>   CONFIG_SYSRESET_TI_SCI=y
>>   CONFIG_FS_FAT_MAX_CLUSTSIZE=16384
>>   CONFIG_EFI_SET_TIME=y
>> +CONFIG_TEE=y
>> +CONFIG_OPTEE=y
>> +CONFIG_TPM=y
>> +CONFIG_TPM_V2=y
>> +CONFIG_CMD_TPM=y
>> +CONFIG_TPM2_FTPM_TEE=y
>> +CONFIG_CMD_OPTEE_RPMB=y
>> +CONFIG_SUPPORT_EMMC_RPMB=y
>> +CONFIG_CMD_MMC_RPMB=y
>>     #include <configs/k3_efi_capsule.config>
>>   #include <configs/am62x_a53_usbdfu.config>
> 

Reply via email to