On 2/25/26 15:37, Tom Rini wrote:
On Wed, Feb 25, 2026 at 11:00:23AM +0100, Heinrich Schuchardt wrote:

Symbol CONFIG_KEYBOARD does not exist.
Don't imply it.

Signed-off-by: Heinrich Schuchardt <[email protected]>
---
  arch/arm/mach-exynos/Kconfig | 1 -
  1 file changed, 1 deletion(-)

diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
index b084b7284aa..06448e875ef 100644
--- a/arch/arm/mach-exynos/Kconfig
+++ b/arch/arm/mach-exynos/Kconfig
@@ -34,7 +34,6 @@ config ARCH_EXYNOS5
        imply CMD_HASH
        imply CRC32_VERIFY
        imply HASH_VERIFY
-       imply KEYBOARD
        imply USB_ETHER_ASIX
        imply USB_ETHER_RTL8152
        imply USB_ETHER_SMSC95XX

Should this be DM_KEYBOARD ? I'm not sure about USB_KEYBOARD instead,
but it looks like USB_KEYBOARD should be a depends on, not selects
DM_KEYBOARD, too.


ARCH_EXYNOS5 depends on ARCH_EXYNOS.
ARCH_EXYNOS selects DM_KEYBOARD.

As DM_KEYBOARD is always selected for ARCH_EXYNOS5 we should be fine with the patch as is.

odroid_defconfig has ARCH_EXYNOS5 but does not enable any keyboard:

.config:198:CONFIG_ARCH_EXYNOS5=y
.config:1218:CONFIG_DM_KEYBOARD=y
.config:1219:# CONFIG_APPLE_SPI_KEYB is not set
.config:1220:# CONFIG_BUTTON_KEYBOARD is not set
.config:1221:# CONFIG_CROS_EC_KEYB is not set
.config:1222:# CONFIG_I8042_KEYB is not set
.config:1663:# CONFIG_USB_KEYBOARD is not set

As the board has no video, adding a USB keyboard would not be helpful.

.config:1682 # CONFIG_VIDEO is not set

Best regards

Heinrich

Reply via email to