Hi Heinrich,
On 2/25/26 10:58 AM, Heinrich Schuchardt wrote:
Symbol CONFIG_KEYBOARD does not exist.
It used to. C.f. f60e6f676764 ("input: Remove legacy KEYBOARD option")
where platforms were all supposed to be migrated to use DM_KEYBOARD.
DM_KEYBOARD is already automatically included for sandbox via the select
mechanism just above the git context here.
Funnily enough, select DM_SANDBOX was added before the imply KEYBOARD.
See 93e1edffb02b ("Convert CONFIG_KEYBOARD to Kconfig") and 558e12571e3c
("sandbox, x86: select DM_KEYBOARD instead of default y entry").
I would recommend a fixes on f60e6f676764 as the symbol should have been
removed there.
Also, there's also a similar imply for exynos, in
arch/arm/mach-exynos/Kconfig. Which also has a companion DM_KEYBOARD
select in arch/arm/Kconfig under the MACH_EXYNOS symbol, so it can be
removed as well. I'll let you figure out the appropriate commit hash for
the Fixes tag.
The change is fine, more info would be welcome (in a v2 for example) but
I don't think it warrants a blocker, as such:
Reviewed-by: Quentin Schulz <[email protected]>
Thanks!
QUentin
