Hi Simon,

On 2/25/26 11:50 PM, Simon Glass wrote:
From: Simon Glass <[email protected]>

The non-dts files should not be numbered. Remove the 340_ prefix from

Why not? Now it's more difficult for me to know which files are supposed to be used with which dts/test.

What do we do once we have a name collision? Start another numbering scheme?

Honestly, I'm wondering if we shouldn't improve ftest to better split tests. Or maybe split ftest.py into multiple files. I very much dislike how we handle input files also. They are set at the class level and any test can modify them. I *guess* it could be fine to have a shared input directory among all tests, but it must be read-only so we don't have side effects (we can then have a per-test rw input directory if necessary).

I guess we could have a subdir per new ftest split which contains all files that pertain to this test. We can group them by theme for example to not have to have a subdir per test and overwhelm the user (though that makes it very explicit what's to be used with what).

The change seems fine so I won't fight against merging it but I don't see a clear benefit for it so I'll refrain from giving this a reviewer tag.

Cheers,
Quentin

Reply via email to