Fix compiler warning:
drivers/serial/ns16550.c: In function ‘serial_in_dynamic’:
drivers/serial/ns16550.c:153:1: warning: control reaches end
of non-void function [-Wreturn-type]
153 | }
| ^
Observed with gcc 15.2.1:
$ riscv64-unknown-linux-gnu-gcc --version
riscv64-unknown-linux-gnu-gcc (Gentoo 15.2.1_p20260214 p5) 15.2.1
Fixes: 62cbde4c4e46 ("serial: ns16550: Support run-time configuration")
Signed-off-by: Nikita Shubin <[email protected]>
---
Changes in v2:
Tom:
- specified gcc version in commit message
- Link to v1:
https://lore.kernel.org/r/20260226-serial_ns16550_fix_warning-v1-1-ea563e6a2...@maquefel.me
---
drivers/serial/ns16550.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c
index 4f7de3ea215..71e2bc026cb 100644
--- a/drivers/serial/ns16550.c
+++ b/drivers/serial/ns16550.c
@@ -140,9 +140,9 @@ static int serial_in_dynamic(struct ns16550_plat *plat, u8
*addr)
}
} else if (plat->flags & NS16550_FLAG_BE) {
return readb(addr + (1 << plat->reg_shift) - 1);
- } else {
- return readb(addr);
}
+
+ return readb(addr);
}
#else
static inline void serial_out_dynamic(struct ns16550_plat *plat, u8 *addr,
---
base-commit: 7995bf8dea2d5b3eb7fcb836636f4773924ec35d
change-id: 20260226-serial_ns16550_fix_warning-51617ddbfb31
Best regards,
--
Nikita Shubin