Le mer. 4 mars 2026 à 17:17, Neil Armstrong
<[email protected]> a écrit :
>
> On 2/10/26 17:22, Julien Stephan wrote:
> > Introduce ufshcd_ops_phy_initialization() as a helper for invoking the
> > phy_initialization callback from ufs_hba_ops.
> >
> > This mirrors the existing helper pattern used for other ufs_hba_ops
> > callbacks and keeps the call sites consistent and easier to maintain.
> >
> > Signed-off-by: Julien Stephan <[email protected]>
> > ---
> > drivers/ufs/ufs-rockchip.c | 10 ++++------
> > drivers/ufs/ufs.h | 8 ++++++++
> > 2 files changed, 12 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/ufs/ufs-rockchip.c b/drivers/ufs/ufs-rockchip.c
> > index 0384244387d..cad753d5990 100644
> > --- a/drivers/ufs/ufs-rockchip.c
> > +++ b/drivers/ufs/ufs-rockchip.c
> > @@ -30,12 +30,10 @@ static int ufs_rockchip_hce_enable_notify(struct
> > ufs_hba *hba,
> > ufshcd_dme_reset(hba);
> > ufshcd_dme_enable(hba);
> >
> > - if (hba->ops->phy_initialization) {
> > - err = hba->ops->phy_initialization(hba);
> > - if (err)
> > - dev_err(hba->dev,
> > - "Phy init failed (%d)\n", err);
> > - }
> > + ret = ufshcd_ops_phy_initialization(hba);
> > + if (err)
> > + dev_err(hba->dev,
> > + "Phy init failed (%d)\n", err);
>
> So this fails with:
> drivers/ufs/ufs-rockchip.c:32:9: error: 'ret' undeclared (first use in this
> function)
> 2342
> 32 | ret = ufshcd_ops_phy_initialization(hba);
>
>
> It should probably be: "err ="
Hi Neil,
Thank you for catching this. I sent a new version.
Sorry for that.
Julien
>
> I'll drop this serie from the PR, please fix and resend a new version.
>
> Neil
>
> >
> > return err;
> > }
> > diff --git a/drivers/ufs/ufs.h b/drivers/ufs/ufs.h
> > index bc839a43704..74125b1ab31 100644
> > --- a/drivers/ufs/ufs.h
> > +++ b/drivers/ufs/ufs.h
> > @@ -756,6 +756,14 @@ static inline int
> > ufshcd_ops_link_startup_notify(struct ufs_hba *hba,
> > return 0;
> > }
> >
> > +static inline int ufshcd_ops_phy_initialization(struct ufs_hba *hba)
> > +{
> > + if (hba->ops && hba->ops->phy_initialization)
> > + return hba->ops->phy_initialization(hba);
> > +
> > + return 0;
> > +}
> > +
> > static inline int ufshcd_vops_device_reset(struct ufs_hba *hba)
> > {
> > if (hba->ops && hba->ops->device_reset)
> >
>
