Dear Peter Feuerer, In message <4e311948.1000...@sysgo.com> you wrote: > Hi, > > when having two (or more) files in cramfs which start with same name, > cramfs_resolve didn't check the filename length and thus returned > potentially the wrong file. > > kind regards, > --peter;
Please move greetings out of the commit message. > Signed-off-by: Peter Feuerer <p...@sysgo.com> > > --- > diff -ur u-boot-2011.06_original/fs/cramfs/cramfs.c > u-boot-2011.06/fs/cramfs/cramfs.c > --- u-boot-2011.06_original/fs/cramfs/cramfs.c 2011-07-28 > 09:48:10.000000000 +0200 > +++ u-boot-2011.06/fs/cramfs/cramfs.c 2011-07-28 09:51:54.000000000 +0200 > @@ -126,7 +126,8 @@ > namelen--; > } > > - if (!strncmp (filename, name, namelen)) { > + if (namelen == strlen (filename) && > + !strncmp (filename, name, namelen)) { Please fix all the errors and warnings reported by checkpatch, and resubmit. Consider using "git format-patch" and "git send-email". Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de It is surely a great calamity for a human being to have no ob- sessions. - Robert Bly _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot