Wolfgang, On Thu, 2011-07-28 at 15:35 +0200, Wolfgang Denk wrote: > Dear York Sun, > > In message <1309457195-8475-1-git-send-email-york...@freescale.com> you wrote: > > Move mac command to board/freescale/common/sys_eeprom.c. > > Change the help message to be more helpful. Print argument format. > > Fix MAX_NUM_PORTS to comply with v1 NXID format. > > > > Signed-off-by: York Sun <york...@freescale.com> > > Why are you turning a generic, board and architecture independent > command into a FSL specific one? >
I believe this "generic" command is only for FSL boards. Moving it to right place. > This makes no sense to me, NAK. > > > board/freescale/common/sys_eeprom.c | 29 ++++++++++++++++++++- > > common/Makefile | 1 - > > common/cmd_mac.c | 49 > > ----------------------------------- > > 3 files changed, 28 insertions(+), 51 deletions(-) > > delete mode 100644 common/cmd_mac.c > > In case you ever move / rename a file: please supply the options so > git will detect the move / copy / rename. The meaningful code was moved into an existing file, so it wasn't renaming a file. York _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot