On Wednesday, August 31, 2011 04:32:52 PM Mike Frysinger wrote:
> On Wednesday, August 31, 2011 06:38:50 Che-Liang Chiou wrote:
> > This patch adds a 64-64 bit divider that supports ARMv4 and above.
> 
> why ?  if you're doing 64 bit divides, chances are you're doing something
> fundamentally wrong.  perhaps you should fix that instead.

Oh come on Mike, what about too big NAND memories ?
> 
> this is also why we have the do_div() helper macro.
> 
> so until your changelog documents the actual *reason* for this patch: NAK

The reason is likely it's faster. But I don't think it matters, that's why I 
commented on this already.

If he's fixing something by this (like I mistakenly did some time ago), there's 
really something wrong.

> -mike
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to