Dear Joel A Fernandes, In message <1313462214-3716-2-git-send-email-agnel.j...@gmail.com> you wrote: > From: Jason Kridner <jkrid...@beagleboard.org> > > Based on commit f1099c7c43caf5bac3bf6a65aa266fade4747072 > Author: Greg Turner <gregtur...@ti.com> > Date: Tue May 25 09:19:06 2010 -0500 > > New u-boot command for status of USER button on BeagleBoard-xM > > Modified bootcmd to check the staus at boot time and set > filename of the boot script. > > * Moved to a BeagleBoard specific file. > * Removed changes to default boot command from adding userbutton > command. > * Made to handle pre-xM boards. > * Flipped polarity of the return value to avoid confusion. Success (0) > is when the button is pressed. Failure (1) is when the button is NOT > pressed. > * Used latest revision getting function. > * Used latest macros for board revision. > * Added xM-C revision definition (optional, since it was default) > * updated default configuration with UserButton functionality > * Added a separate bootenv variable to load a user defined .txt file > * Added an example, showing how a different environment file can be loaded > with > the user button pressed
Your patch has a large number of cding style issues; please always run checkpatch before submitting patches. Also, I agree with Albert: there should be no need for a separate userbutton command. Please fix and resubmit. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The average woman would rather have beauty than brains, because the average man can see better than he can think. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot