On 09/12/2011 10:14 AM, Lukasz Majewski wrote: > On Thu, 01 Sep 2011 11:13:30 +0200 > Lukasz Majewski <l.majew...@samsung.com> wrote: > >> This patch series add support for MAXIM's MAX8998 power IC chip. >> It also enables usage of it on the GONI reference target. >> >> Lukasz Majewski (2): >> misc:max8998 Support for MAX8998 PMIC driver >> misc:samsung:s5p Enable MAX8998 support at GONI reference target >> > > Dear all, >
Hi Lukasz, > Is there any feedback/comments for those patches? > MAX8998 PMIC patches were posted some time ago and no response has been > received. >From my site I promise I will get a look at it. At the moment I have a big question. I see your code is quite similar to other ones (fsl_pmic.c is what I know better..). I remember there was already a discussion about another pmic, whose patch reassembled some drivers in u-boot. My big question is: if we have a similar mechanism to access the PMICs (SPI/I2C), should we not to found a way to generalize it ? This kind of driver has only some pmic_read/pmic_write functions. Maybe getting rid of special manufacturer names as fsl_pmic, max_pmic... and using a general access for this kind of chips ? From code your patch is not very distant from what we currently have. Any opinion about this ? > > BTW. On the "u-boot Custodians" page I haven't found anyone responsible > for driver/misc. You are right. > Is there appropriate person for this, or shall it be > addressed to Wolfgang? I do not know - however, your driver is not strictly related to a specific SOC, and could be used by any architecture. We can consider it as general code, and I added Wolfgang in CC to ask his opinion. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de ===================================================================== _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
