On Wednesday, September 28, 2011 02:25:14 PM Jana Rapava wrote: > 2011/9/28 Marek Vasut <marek.vasut.n...@gmail.com> > > > > + /* get ID from ULPI immediate registers */ > > > + for (reg = ULPI_ID_REGS_COUNT - 1; reg >= 0; reg--) > > > + tmp |= ulpi_read(ehci, (u32)reg) << (reg * 8); > > > > Are you ignoring my comment and picking only some of them? Is the cast > > here necessary? > > Sorry, I try to change patches according to your requests, but sometimes I > overlook something. > Also, it looks like I forgot to add proper header to efikamx-usb.c. Should > I add it in the next version?
yes ... Copyright (C) 2011 Marek Vasut <marek.va...@gmail.com> Copyright (C) 2011 Jana Rapava <ferma...@gmail.com> > > > > + /* USB 2.0 specification say 50 ms resets on root. */ > > > > Where can I read about this please? > > Universal Serial Bus Specification Revision 2.0, chapter 7.1.7.5 Reset > Signaling says: "It is required that resets from root ports have a duration > of at least 50 ms (TDRSTR)." OK > > Regards, > Jana Rapava _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
