Am 26/09/2011 17:10, schrieb Lukasz Majewski: > This patch series adds new generic PMIC framework for u-boot. > It is supposed to handle various types of pmic IC's (both > I2C and SPI). >
Hi Lukasz, > This patch series has been tested on Samsung's GONI reference target. > > Moreover a special patch for mx51evk target board has been prepared. > It is compiling, but I cannot test if the driver works. I have tested the SPI part on a different board instead of MX51EVK(vision2). I think you can forget for your patchset about MX5 boards - they can be switched to the general pmic_core when the fsl_pmic file will be dropped and after merging your patches. Thanks in any case to have provided an example ;-) > Other iMX targets shall be corrected in a similar way that mx51evk. > > The old fsl_pmic.c driver has been preserved. Ok - it will be removed after including you patches. The write function is symmetric to the read function: int pmic_reg_write(struct pmic *p, u32 reg, u32 *val) However, we do not want to change the value pointed by val. I think it is should better to pass a u32 instead of a pointer. > > Lukasz Majewski (3): > misc:pmic New generic pmic driver > misc:pmic: Enable PMIC handling at u-boot startup code > misc:pmic:mx: Code modification for mx51evk board > > arch/arm/lib/board.c | 5 + > board/freescale/mx51evk/mx51evk.c | 68 ++++++++++++------ > drivers/misc/Makefile | 6 +- > drivers/misc/pmic_core.c | 148 > +++++++++++++++++++++++++++++++++++++ > drivers/misc/pmic_fsl.c | 57 ++++++++++++++ > drivers/misc/pmic_i2c.c | 92 +++++++++++++++++++++++ > drivers/misc/pmic_max8998.c | 43 +++++++++++ > drivers/misc/pmic_spi.c | 109 +++++++++++++++++++++++++++ > include/configs/mx51evk.h | 6 +- > include/configs/s5p_goni.h | 4 + > include/fsl_pmic.h | 5 +- > include/max8998_pmic.h | 84 +++++++++++++++++++++ > include/pmic.h | 71 ++++++++++++++++++ Logically I see your patchset split into 3 patches, but differently as you did: - adding pmic core driver - adding support for max8998 - adding pmic to the s5p_goni Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de ===================================================================== _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot