On Monday, September 26, 2011 20:10:55 Simon Glass wrote:
> --- a/Makefile
> +++ b/Makefile
>
> +ifneq ($(CPU),sandbox)
>  OBJS  = $(CPUDIR)/start.o
> +endif

if you moved arch/sandbox/common/main.c to arch/sandbox/cpu/start.c, you 
wouldn't need this.  and logically, it seems like a good place for main() to 
be ...

> +ifeq ($(CONFIG_SANDBOX),y)
> +GEN_UBOOT = \
> +             cd $(LNDIR) && $(CC) $(SYMS) -T $(obj)u-boot.lds \
> +                     -Wl,--start-group $(__LIBS) -Wl,--end-group \
> +                     $(PLATFORM_LIBS) -Wl,-Map -Wl,u-boot.map -o u-boot

unfortunate that you can't utilize UNDEF_SYM ...

>  GEN_UBOOT = \
> -             UNDEF_SYM=`$(OBJDUMP) -x $(LIBBOARD) $(LIBS) | \
> -             sed  -n -e 
> 's/.*\($(SYM_PREFIX)__u_boot_cmd_.*\)/-u\1/p'|sort|uniq`;
> +             UNDEF_SYM=`$(UNDEF)`; \

i don't see you defining "UNDEF" anywhere in this patch series ...
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to