Mike,
On Fri, Sep 30, 2011 at 21:21:34, Mike Frysinger wrote:
> On Friday, September 30, 2011 07:24:26 nagabhushana.netagu...@ti.com wrote:
> > + if (is_multicast_ether_addr(buff) ||
> > + is_zero_ether_addr(buff)) {
>
> NAK: use is_valid_ether_addr()
Thanks. Changed this.
>
> > + sprintf((char *)enetaddr, "%pM", buff);
> > +
> > + eth_setenv_enetaddr("ethaddr", enetaddr);
>
> NAK: eth_setenv_enetaddr() does the sprintf for you -mike
Thanks Mike. I have removed the sprintf.
>
Also,
I will be taking care of the patch set from now. I will resubmit the patches
with the changes.
Thx,
-Manju
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
