Dear Marek Vasut, In message <1317990657-17214-2-git-send-email-marek.va...@gmail.com> you wrote: > Also, fix usb drivers which use extern new. > > Signed-off-by: Marek Vasut <marek.va...@gmail.com> > Cc: Ajay Kumar Gupta <ajay.gu...@ti.com> > Cc: Bryan Wu <bryan...@analog.com> > Cc: Cliff Cai <cliff....@analog.com> > Cc: Mike Frysinger <vap...@gentoo.org> > Cc: Remy Bohmer <li...@bohmer.net> > Cc: Wolfgang Denk <w...@denx.de> > --- > common/usb_kbd.c | 644 > ++++++++++++++++++++++++------------------- > drivers/usb/host/ehci-hcd.c | 20 +-- > drivers/usb/musb/musb_hcd.c | 19 +-- > include/usb.h | 1 + > 4 files changed, 369 insertions(+), 315 deletions(-) > > NOTE: Tested on EfikaSB device, but please test on some more hardware first! > > diff --git a/common/usb_kbd.c b/common/usb_kbd.c > index 503d175..d19551b 100644 > --- a/common/usb_kbd.c > +++ b/common/usb_kbd.c > @@ -25,402 +25,490 @@ > * > */ > #include <common.h> > +#include <malloc.h> > #include <stdio_dev.h> > #include <asm/byteorder.h> > > #include <usb.h> > > -#undef USB_KBD_DEBUG > +/* USB Keyboard Debug */ > +#undef USB_KBD_DEBUG
Please do not undef what is not defined [or what a user might want to define on the command line]. > +/* Keyboard sampling rate */ > +#define REPEAT_RATE (40 / 4) /* 40msec -> 25cps */ > +#define REPEAT_DELAY 10 /* 10 x REAPEAT_RATE = 400msec > */ Please fix the typo while you are at it. And please split code changes and pure cosmetic ones into separate commits. Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de I'm what passes for a Unix guru in my office. This is a frightening concept. - Lee Ann Goldstein, in <3k55ba$c...@butch.lmsc.lockheed.com> _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot