On Sun, Oct 9, 2011 at 12:11 PM, Wolfgang Denk <w...@denx.de> wrote:
> Dear Anton Staaf,
>
> In message
> <CAF6FioV3YFk02Sgp0AasYGQJSNKv=cb-sszcqr8f3s2esya...@mail.gmail.com> you
> wrote:
>>
>> > This is needed for the patch "cache: add default setting for
>> > CONFIG_SYS_CACHELINE_SIZE" from Anton Staaf. As cache.h defines
>> > CONFIG_SYS_CACHELINE_SIZE for PPC targets.
>> >
>> > This will remove the following warnings/errors:
>> >
>> > include/common.h:819:2: warning: #warning CONFIG_SYS_CACHELINE_SIZE not d=
>> efined, using __BIGGEST_ALIGNMENT__
>> > cache.c:33: error: '__BIGGEST_ALIGNMENT__' undeclared (first use in this =
>> function)
> ...
>> It would be great if this could be enabled for all configs, not just
>> PPC. Would it make sense to remove this check and add #ifndef
>> __ASSEMBLY__ to the other cache.h files? The list is not too long
>> (m68k, sparc, sh, nios2, and arm). I'd be happy to look into that if
>> you'd rather get this in first.
>
> Agreed. But please let's do this in a second step (feel free to
> submit a patch :-)
Will do. :)
Thanks,
Anton
> I suggest to just add this under #ifndef __ASSEMBLY__
>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
> Never put off until tomorrow what you can put off indefinitely.
>
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
