On 10/10/2011 10:50 AM, Heiko Schocher wrote: > Hello Stefano, > > Stefano Babic wrote: >> The function i2c_set_bus_num() is used on most SOCs. >> The driver does not support multiple I2C busses, and >> an empty function is added to be compatible with general code >> (example: PMIC driver). >> >> Signed-off-by: Stefano Babic <sba...@denx.de> >> Cc: Heiko Schocher <h...@denx.de> >> --- >> drivers/i2c/mxc_i2c.c | 5 +++++ >> 1 files changed, 5 insertions(+), 0 deletions(-) > > Hmm... it would be better to add a weak function in > u-boot/common/cmd_i2c.c ... as it is done for i2c_set_bus_speed() > and i2c_get_bus_speed() functions.
Good idea, I missed it..changed in V2. Stefano -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de ===================================================================== _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot