Hi Wofgang, On Mon, Oct 17, 2011 at 1:21 PM, Simon Glass <s...@chromium.org> wrote: > Hi Wolfgang, > > On Mon, Oct 17, 2011 at 1:06 PM, Wolfgang Denk <w...@denx.de> wrote: >> Dear Simon Glass, >> >> In message <1314633910-8550-2-git-send-email-...@chromium.org> you wrote: >>> Tested-by: Simon Glass <s...@chromium.org> >>> Signed-off-by: Simon Glass <s...@chromium.org> >>> --- >>> include/common.h | 8 ++++++++ >>> lib/vsprintf.c | 26 ++++++++++++++++++++++++-- >>> 2 files changed, 32 insertions(+), 2 deletions(-) >> >> Can we please make this feature conditional, so that boards that are >> not going to use it don't have to suffer from the increased code size? >> > > We can easily make some of it conditional (the exported functions), > but some of it is changes to make the low-level formatter respect an > 'end' pointer. I will take a look as there might be something clever > we can do there. We would also need to add, for example, an snprintf() > macro which drops the numeric parameter, so that code which uses > snprintf() continues to work. > > Regards, > Simon > >> Thanks. >>
I was thinking of your code size comments in snprintf() when I wrote this - I sent another patch today which deals with that. I am hoping that that will remove one more barrier to To address your comment here the code size increase is 42 bytes on ARMv7 with this option. The patch I have just sent makes it optional. Regards, Simon >> Best regards, >> >> Wolfgang Denk >> >> -- >> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel >> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany >> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de >> "The combination of a number of things to make existence worthwhile." >> "Yes, the philosophy of 'none,' meaning 'all.'" >> -- Spock and Lincoln, "The Savage Curtain", stardate 5906.4 >> > _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot