Hi Wolfgang, On Sun, Oct 23, 2011 at 11:44 AM, Wolfgang Denk <w...@denx.de> wrote: > Dear Simon Glass, > > In message <1318790446-24792-3-git-send-email-...@chromium.org> you wrote: >> This changes the number 15 as used in boot_stage_progress() to use the >> new name provided for it, >> >> Signed-off-by: Simon Glass <s...@chromium.org> > ... > >> - show_boot_progress (15); >> + show_boot_progress(BOOTSTAGE_ID_RUN_OS); > > To maintain consistent operation of the show_boot_progress() > implementation, you should also replace all ocurrances of > > show_boot_progress(-15); > with > show_boot_progress(-BOOTSTAGE_ID_RUN_OS);
I couldn't find any of those - perhaps I should chosen a better example since I did mean to ask about those -ve numbers. IMHO we would be better off with a function call like show_boot_error(BOOTSTAGE_ID_RUN_OS); even if this is a macro. It is more explicit about the fact that we are reporting an error. Does that sound ok? Regards, Simon > > > Best regards, > > Wolfgang Denk > > -- > DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de > I was playing poker the other night... with Tarot cards. I got a full > house and 4 people died. - Steven Wright > _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot