Dear Mike Frysinger,
In message <CAJaTeTpeNDdV4g+n4cE0GVe8uBxgjUdRhrF2t=q-pob5pam...@mail.gmail.com>
you wrote:
> On Fri, Oct 28, 2011 at 07:49, Wolfgang Denk wrote:
> > --- a/drivers/net/e1000.h
> > +++ b/drivers/net/e1000.h
> >
> > #define E1000_WRITE_FLUSH(a) \
> > - do { uint32_t x = E1000_READ_REG(a, STATUS); } while (0)
> > + E1000_READ_REG(a, STATUS)
>
> i think we want the do{}while as this is a write command and we don't
> want people accidentally trying to check the return value
I don't see that this is a write command. I'm seeing only reading of
the status register here.
And I don't understand the "accidentally trying to check the return
value" argument either. Why would one do that - and if one does
(probably after checking the implementation), what would be wrong
about it?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
My play was a complete success. The audience was a failure.
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
