Hi Albert, On Tue, Oct 25, 2011 at 2:25 PM, Albert ARIBAUD <albert.u.b...@aribaud.net> wrote: > Le 25/10/2011 08:15, Albert ARIBAUD a écrit : >> >> Hi Lei Wen, >> >> Le 25/10/2011 03:21, Lei Wen a écrit : >>> >>> Hi Albert, >>> >>> On Tue, Oct 25, 2011 at 1:20 AM, Albert ARIBAUD >>> <albert.u.b...@aribaud.net> wrote: >>>> >>>> Hi Lei Wen, >>>> >>>> Le 04/10/2011 08:33, Lei Wen a écrit : >>>>> >>>>> This patch seris add the mmc support for the pantheon platform. >>>>> Also give platform like dkb and aspenite a workaround when enabling >>>>> the 8bit mode for accessing the mmc. >>>>> >>>>> Changelog: >>>>> V2: remove magic number, and replace it by macro definition and >>>>> structure >>>>> respectively. >>>>> remove enable mmc function into seperated patch >>>>> >>>>> Lei Wen (4): >>>>> ARM: pantheon: add mmc definition >>>>> Marvell: dkb: add mmc support >>>>> dkb: make mmc command as default enabled >>>>> mmc: mv_sdhci: fix 8bus width access for 88SV331xV5 >>>> >>>> This causes a lot of build errors on dkb with ELDK42: >>>> >>>> Configuring for dkb board... >>>> In file included from mv_sdhci.c:3: >>>> /home/uboot/src/u-boot-arm/include/sdhci.h:224: warning: 'struct >>>> sdhci_host' declared inside parameter list >>>> /home/uboot/src/u-boot-arm/include/sdhci.h:224: warning: its scope is >>>> only this definition or declaration, which is probably not what you want >>>> /home/uboot/src/u-boot-arm/include/sdhci.h:225: warning: 'struct >>>> sdhci_host' declared inside parameter list >>>> /home/uboot/src/u-boot-arm/include/sdhci.h:226: warning: 'struct >>>> sdhci_host' declared inside parameter list >>>> /home/uboot/src/u-boot-arm/include/sdhci.h:227: warning: 'struct >>>> sdhci_host' declared inside parameter list >>>> /home/uboot/src/u-boot-arm/include/sdhci.h:228: warning: 'struct >>>> sdhci_host' declared inside parameter list >>>> /home/uboot/src/u-boot-arm/include/sdhci.h:229: warning: 'struct >>>> sdhci_host' declared inside parameter list >>>> /home/uboot/src/u-boot-arm/include/sdhci.h: In function 'sdhci_writel': >>>> /home/uboot/src/u-boot-arm/include/sdhci.h:247: warning: passing >>>> argument 1 of 'host->ops->write_l' from incompatible pointer type >>>> /home/uboot/src/u-boot-arm/include/sdhci.h: In function 'sdhci_writew': >>>> /home/uboot/src/u-boot-arm/include/sdhci.h:255: warning: passing >>>> argument 1 of 'host->ops->write_w' from incompatible pointer type >>>> /home/uboot/src/u-boot-arm/include/sdhci.h: In function 'sdhci_writeb': >>>> /home/uboot/src/u-boot-arm/include/sdhci.h:263: warning: passing >>>> argument 1 of 'host->ops->write_b' from incompatible pointer type >>>> /home/uboot/src/u-boot-arm/include/sdhci.h: In function 'sdhci_readl': >>>> /home/uboot/src/u-boot-arm/include/sdhci.h:271: warning: passing >>>> argument 1 of 'host->ops->read_l' from incompatible pointer type >>>> /home/uboot/src/u-boot-arm/include/sdhci.h: In function 'sdhci_readw': >>>> /home/uboot/src/u-boot-arm/include/sdhci.h:279: warning: passing >>>> argument 1 of 'host->ops->read_w' from incompatible pointer type >>>> /home/uboot/src/u-boot-arm/include/sdhci.h: In function 'sdhci_readb': >>>> /home/uboot/src/u-boot-arm/include/sdhci.h:287: warning: passing >>>> argument 1 of 'host->ops->read_b' from incompatible pointer type >>>> mv_sdhci.c: In function 'mv_sdhci_writeb': >>>> mv_sdhci.c:14: error: 'struct sdhci_host' has no member named 'mmc' >>>> mv_sdhci.c:17: warning: implicit declaration of function 'IS_SD' >>>> mv_sdhci.c:18: error: dereferencing pointer to incomplete type >>>> mv_sdhci.c: In function 'mv_sdh_init': >>>> mv_sdhci.c:48: warning: assignment from incompatible pointer type >>>> >>> >>> Actually, I have post another fixing series before this, so if it got >>> be applied before this merged, >>> the warning would be disappeared. >>> >>> You could refer to: >>> http://permalink.gmane.org/gmane.comp.boot-loaders.u-boot/111621 >> >> Thanks for the pointer -- please next time indicate the dependency on >> any patch set not yet applied at the time. > > I've tried applying the patches in the link you refer to, then the patch > series given here, but the latter does not apply properly above the former > on top of u-boot-arm/master. Can you check this? > >>> Best regards, >>> Lei > >
I try to rebase the V4 of sdhci fixing patch over latest u-boot-arm.git, and find there is no problem... Could you help check again? Thanks, Lei _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot