Dear Gabe Black, In message <1320443602-2677-1-git-send-email-gabebl...@chromium.org> you wrote: > --===============1488196431== > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit > > From: Gabe Black <gabebl...@google.com> > > Signed-off-by: Gabe Black <gabebl...@chromium.org> > --- > Changes in v2: > Get rid of some dead/unnecessary code in the Makefile and coreboot.c.
v2 ????? ... > +int board_early_init_f(void) > +{ > + return 0; > +} Drop empty functions. > + /* CPU Speed to 100MHz */ > + gd->cpu_clk = 100000000; > + > + /* Crystal is 33.000MHz */ > + gd->bus_clk = 33000000; You should use #defines for these. > +void show_boot_progress(int val) > +{ > +} > + > + > +int last_stage_init(void) > +{ > + return 0; > +} > + > +#ifndef CONFIG_SYS_NO_FLASH > +ulong board_flash_get_legacy(ulong base, int banknum, flash_info_t *info) > +{ > + return 0; > +} > +#endif Drop empty functions. > +void setup_pcat_compatibility() > +{ > +} Drop empty functions. > +void pci_init_board(void) > +{ > +} Drop empty functions. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de They say, well, meybe it _is_ smelly, maybe it _is_ overcrowded, may- be it _is_ a bit like Hell would be if they shut the fires off and stabled a herd of incontinent cows there for a year, but you must admit that it is full of sheer, vibrant, dynamic _life_. - Terry Pratchett, _Moving Pictures_ _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot