Re: [U-Boot] [PATCH] arm, post: add missing post_time_ms for arm

[Mike Frysinger]

On Thursday 15 September 2011 01:34:33 Heiko Schocher wrote:
> Signed-off-by: Heiko Schocher <h...@denx.de>
> Cc: Albert ARIBAUD <albert.u.b...@aribaud.net>
> ---
>  post/post.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/post/post.c b/post/post.c
> index 6c59f91..0bfca75 100644
> --- a/post/post.c
> +++ b/post/post.c
> @@ -488,7 +488,7 @@ void post_reloc(void)
>   */
>  unsigned long post_time_ms(unsigned long base)
>  {
> -#ifdef CONFIG_PPC
> +#if defined(CONFIG_PPC) || defined(CONFIG_ARM)
>       return (unsigned long)(get_ticks() / (get_tbclk() / CONFIG_SYS_HZ))
>               - base;
>  #else

almost no one uses the result of post_time_ms(), so the warning ends up being 
spurious for most people.

are you enabling this define because you need the result ?  or you just trying 
to kill the warning ?  if the latter, i think we should make this so it warns 
only when appropriate ...
-mike

signature.asc
Description: This is a digitally signed message part.

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot