Hi Igor, sorry for the late answer.
On 30.11.2011 11:42, Igor Grinberg wrote: >> diff --git a/arch/arm/cpu/arm926ejs/davinci/dp83848.c >> b/arch/arm/cpu/arm926ejs/davinci/dp83848.c >> index c71c685..d435e4b 100644 >> --- a/arch/arm/cpu/arm926ejs/davinci/dp83848.c >> +++ b/arch/arm/cpu/arm926ejs/davinci/dp83848.c >> @@ -29,6 +29,7 @@ >> #include <net.h> >> #include <dp83848.h> >> #include <asm/arch/emac_defs.h> >> +#include "../../../../../drivers/net/davinci_emac.h" > > Doesn't this look terrible? Yes, it does. But this will be removed once someone will switch the driver to phylib. > I'd suggest, to split the davinci_emac.h to driver private part > (if there is) and to public part. > Then put the public part into the include/ directory - just as, > for example, dm9000 does. Uh.. As for me, polluting the public includes is not very good idea as well. And again I think switching to phylib use is the right solution. This should be rather simple. Regards, Ilya. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot