> On Saturday 10 December 2011 20:09:30 Marek Vasut wrote: > > Introduce ne2k_register_io(in, out), which allows user to supply two > > functions. One for reading data from the card, the other for writing data > > to the card. Then introduce drivers' private data, which carry pointers > > to these functions and are passed throughout the driver. > > where are the users of this new API ? as it stands, i just see bloat. > every register access is now an indirect function call ? what's the point
Go to ... drivers/net/ax88796.h ... and check how it's done now. It's just wrong. Now for .03 release I have pxa3xx support ready which uses just this chip and adding more sh^Htuff to that fill would be even worse bloat. M _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
