On 18/12/2011 18:56, Kumar Gala wrote: > > On Dec 16, 2011, at 3:42 AM, Stefano Babic wrote: > >> On 16/12/2011 10:33, Fabio Estevam wrote: >> >>> >>> The weak function was introduced by this commit: >>> http://git.denx.de/?p=u-boot.git;a=commitdiff;h=97039ab98c551c7860bc0977d684ef686159e0d7 >>> >>> which breaks non CONFIG_FSL_ESDHC users. >> >> Ok, I see - the patch is more related to Freescale SOCs as to the MMC, >> and it is sometimes unknown who whould pick it up. >> >> Andy, not CONFIG_FSL_ESDHC means IMX users - if you do not complain, I >> merge it into u-boot-imx. >> >> Thanks, >> Stefano > > If I'm reading the patch correct it will break things (or I'm not sure which > patch you're referring to). How would the PPC specific version ever get > called?
Yes, I was too optimistic with the patch, I have myself seen that the patch then break PowerPC boards. Reading sdhc_boot.c, this file is not strictly related to PowerPC or IMX hardware, but where u-boot image is stored on PowerPC code. This is like a specific feature, but there is not a specific CONFIG_ for it. In fact, in board/freescale/common/Makefile the file is always compiled if CONFIG_RAMBOOT_PBL (not significant for imx) is not set if the environment is in MMC: ifndef CONFIG_RAMBOOT_PBL COBJS-$(CONFIG_ENV_IS_IN_MMC) += sdhc_boot.o endif What about to have a specific CONFIG_FSL_* for this file ? It can be defined for PowerPC boards, and it will not for IMX. Any thoughts ? Stefano -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de ===================================================================== _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
