Dear Wolfgang Denk, On Tue, Jan 10, 2012 at 2:16 PM, Wolfgang Denk <w...@denx.de> wrote: > In which way would this approach avoid the problem (potential overflow > of cmdline max size) that you are trying to fix with your patch?
The overflow will be avoided on any boards that don't define CONFIG_DEPRECATED_SILENT_LINUX_CONSOLE. As of the third version of this patch (will be sent shortly), the Blackfin board will be fixed so that the overflow can't happen on that board. > So you actually do not fix any problem, but you remove existing > functionality that has been used in a number of projects, so you > actually break a number of boards. With the third version of this patch the Blackfin board is one example of a board that is fixed. On all other boards, no functionality is lost and no bugs are fixed. Previously I had submitted a patch to fix the overflow itself, which you NAKed (saying that fixup_silent_linux() was deprecated and shouldn't get any bugfixes). I am happy to dig that up and re-post it if you'd prefer. Either option is fine with me. My problem is that I have a board that would like to use CONFIG_SILENT_CONSOLE (to silence the U-Boot console) and have a Linux command line that is >256 characters. I either need the overflow fixed (my previous patch) or some way to avoid it (this patch). Thanks much! -Doug _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot