Hello Jens, Jens Scharsig wrote: > Hello Heiko: >> Please check your patch with tools/checkpatch, it shows a lot >> of warnings: >> >> [hs@pollux u-boot]$ ./tools/checkpatch.pl index.html >> [...] >> total: 17 errors, 13 warnings, 1131 lines checked >> > The error based on the two code sequences > > <snip> > > vidinfo_t panel_info = { > vl_col: 320, > vl_row: 240, > vl_clk: 6500000, > vl_sync: ATMEL_LCDC_INVDVAL_INVERTED | > ATMEL_LCDC_INVLINE_INVERTED | > ATMEL_LCDC_INVVD_INVERTED | > ATMEL_LCDC_INVFRAME_INVERTED, > vl_bpix: (ATMEL_LCDC_PIXELSIZE_8 >> 5), > vl_tft: 1, > vl_hsync_len: 5, /* Horiz Sync Pulse Width */ > vl_left_margin: 68, /* horiz back porch */ > vl_right_margin: 20, /* horiz front porch */ > vl_vsync_len: 2, /* vert Sync Pulse Width */ > vl_upper_margin: 18, /* vert back porch */ > vl_lower_margin: 4, /* vert front porch */ > mmio: ATMEL_BASE_LCDC, > };
Try: vidinfo_t panel_info = { .vl_col = 320, [...] > </sinp> > > This block i have "stolen" from at91sam9263 board. > > and > <snip> > #define CONFIG_ETHADDR 00:4D:41:02:52:43 /* MA2SC */ > </sinp> > > Can your teach me the right format for things like this? Hmm.. fix ethaddr in config file? I am not sure, if this is allowed in mainline ... bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot