Re: [U-Boot] [PATCH v5 5/9] Don't include standard parser if hush is used

[Mike Frysinger]

On Wednesday 15 February 2012 00:59:22 Simon Glass wrote:
> This saves about 1KB of code space on ARM with CONFIG_SYS_HUSH_PARSER
> defined.
> 
> --- a/common/main.c
> +++ b/common/main.c
> @@ -1132,6 +1132,7 @@ int parse_line (char *line, char *argv[])
> 
>  /*************************************************************************
> ***/
> 
> +#ifndef CONFIG_SYS_HUSH_PARSER
>  static void process_macros (const char *input, char *output)
>  {
>       char c, prev;
> @@ -1382,6 +1383,7 @@ static int builtin_run_command(const char *cmd, int
> flag)
> 
>       return rc ? rc : repeatable;
>  }
> +#endif

not sure why this is needed ... this wraps two static funcs, so gcc should be 
able to see that they're unused and automatically delete them shouldn't it ?  
why do you need the explicit ifdef ?
-mike

signature.asc
Description: This is a digitally signed message part.

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot