Hi, On Fri, Mar 9, 2012 at 1:00 PM, Stephen Warren <[email protected]> wrote: > On 03/09/2012 01:32 PM, Simon Glass wrote: >> Sometimes we want to be sure that the output FIFO has fully drained (e.g. >> because we are about to reset or the port or reset the board). Add a >> function for this. >> >> Signed-off-by: Simon Glass <[email protected]> > > The series, > > Tested-by: Stephen Warren <[email protected]> > > Tom, > > I'm OK with you adding these patches to u-boot-tegra/master and sending > a pull request for that. Just please put these patches before any that > actually enable CONFIG_OF_CONTROL for any boards, so there's never a > window of broken commits. > > I think it'd be nice at this stage to also drop the commit that turns > Ventana into a DT board, since re-using the Seaboard .dts file for > Ventana isn't correct. However, IIRC that commit was added to WAR some > build issue with Simon's patch series? If that's still a problem, then > I'm OK with converting Ventana if we have to, but we'll need to be very > careful that tegra-seaboard.dts doesn't add stuff that'll fail on, or > damage, Ventana.
A few points: 1. Yes you can drop the Ventana commit and I agree it is a good idea. We should have a real Ventana .dts file I think. Ventana should built ok without a device tree now. The problem was in my clock.c patch. 2. I have held off responding to Stephen's patch on the ML to see what other say. My view is that it is controversial since it changes the so-far accepted meaning of u-boot.bin and the behaviour of the U-Boot Makefile. Plus it is not really necessary as a means of informing the user since we put the pre-console putc() for exactly this problem. So I would rather leave Stephen's patch out at until people have time to decide that I am wrong about it. We already have CONFIG_OF_EMBED to build the fdt into u-boot.bin. Grant Likely had big reservations about this feature - let's not bring it in by stealth. Regards, Simon _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
