Hi Graeme, On Wed, Mar 14, 2012 at 7:29 PM, Graeme Russ <graeme.r...@gmail.com> wrote: > Hi Simon, > > On Thu, Mar 15, 2012 at 1:16 PM, Simon Glass <s...@chromium.org> wrote: >> We can use the declarations of __bss_start and _end from this header >> instead of declaring them locally. >> >> Signed-off-by: Simon Glass <s...@chromium.org> >> --- >> Changes in v4: >> - Use asm/sections.h instead of asm-generic/sections.h >> >> examples/standalone/stubs.c | 7 +++---- >> 1 files changed, 3 insertions(+), 4 deletions(-) >> >> diff --git a/examples/standalone/stubs.c b/examples/standalone/stubs.c >> index 15e9afc..8fb1765 100644 >> --- a/examples/standalone/stubs.c >> +++ b/examples/standalone/stubs.c >> @@ -217,16 +217,15 @@ void __attribute__((unused)) dummy(void) >> #include <_exports.h> >> } >> >> -extern unsigned long __bss_start, _end; >> +#include <asm/sections.h> >> >> void app_startup(char * const *argv) >> { >> - unsigned char * cp = (unsigned char *) &__bss_start; >> + char *cp = __bss_start; >> >> /* Zero out BSS */ >> - while (cp < (unsigned char *)&_end) { >> + while (cp < _end) >> *cp++ = 0; >> - } >> >> #if defined(CONFIG_X86) >> /* x86 does not have a dedicated register for passing global_data */ >> -- >> 1.7.7.3 >> > > Does not look like x86 to me - looks like common code
Yes that tag is wrong. Should I re-issue the patch? Regards, Simon > > Regards, > > Graeme _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot