Hi Joe, On Tue, Mar 27, 2012 at 4:42 PM, Joe Hershberger <joe.hershber...@ni.com> wrote: > Signed-off-by: Joe Hershberger <joe.hershber...@ni.com> > Cc: Joe Hershberger <joe.hershber...@gmail.com> > Cc: Simon Glass <s...@chromium.org> > Cc: Mike Frysinger <vap...@gentoo.org>
I have a suggestion below that you might want to take up, but otherwise: Acked-by: Simon Glass <s...@chromium.org> > --- > Changes for v2: > - Remove volatile from eth driver API > - Not using global NetRxPacket (since not casting away volatile) > > include/net.h | 25 +++++++++++++------------ > net/bootp.c | 4 ++-- > net/eth.c | 12 +++++------- > net/net.c | 34 +++++++++++++++++----------------- > net/rarp.c | 2 +- > net/tftp.c | 6 +++--- > 6 files changed, 41 insertions(+), 42 deletions(-) > > diff --git a/include/net.h b/include/net.h > index 5560785..883fd1b 100644 > --- a/include/net.h > +++ b/include/net.h > @@ -407,10 +408,10 @@ extern void NetStartAgain(void); > extern int NetEthHdrSize(void); > > /* Set ethernet header; returns the size of the header */ > -extern int NetSetEther(volatile uchar *, uchar *, uint); > +extern int NetSetEther(uchar *, uchar *, uint); I wonder if you can add parameters names into this one and others below as well while you are here. It at least gives some clue as to the parameters even if we don't document them yet. You may intend to do this in later patches, since this is only for checkpatch. Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
