Hi Sebastian, On Tue, Apr 3, 2012 at 3:54 PM, Sebastian Andrzej Siewior <bige...@linutronix.de> wrote: > On 04/03/2012 10:42 PM, Mike Frysinger wrote: >> >> On Friday 23 March 2012 16:11:19 Sebastian Andrzej Siewior wrote: >>> >>> --- a/drivers/net/tsec.c >>> +++ b/drivers/net/tsec.c >>> >>> + if (strcmp(getenv("stdout"), "nc")) >> >> >> i really don't like special casing devices like this
In this case I think it is better to check if stdout is nc, but not to explicitly write to serial_printf(). The nc device is the reason to avoid printing this since it uses the network. The serial_printf seems like the special case to avoid. Consider the case of using a SPI UART. There is no reason these traces should not go to it via the normal printf routing. >> >>> - serial_printf("Speed: %d, %s duplex%s\n", phydev->speed, >>> - (phydev->duplex) ? "full" : "half", >>> - (phydev->port == PORT_FIBRE) ? ", fiber mode" : >>> ""); >>> + serial_printf("Speed: %d, %s duplex%s\n", phydev->speed, >>> + (phydev->duplex) ? "full" : "half", >>> + (phydev->port == PORT_FIBRE) ? ", fiber >>> mode" >>> + : ""); >> >> >> why not just delete this line completely ? > > > *I* don't mind but others might complain about missing important > information. So in my re-do of the series I remove it instead and see > what happens. It is pretty typical to print the result of the auto-negotiation. Are you working on an updated series? Thanks, -Joe _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot