Hi Tom, On Mon, Apr 9, 2012 at 2:50 PM, Tom Warren <twar...@nvidia.com> wrote: > Simon/Stephen, > >> -----Original Message----- >> From: s...@google.com [mailto:s...@google.com] On Behalf Of Simon Glass >> Sent: Monday, April 09, 2012 2:24 PM >> To: Stephen Warren >> Cc: U-Boot Mailing List; Tom Warren >> Subject: Re: [PATCH v3 06/23] tegra: Move ap20.h header into arch location >> >> Hi Stephen, >> >> On Mon, Apr 9, 2012 at 2:06 PM, Stephen Warren <swar...@wwwdotorg.org> >> wrote: >> > On 04/02/2012 05:18 PM, Simon Glass wrote: >> >> We want to include this from board code, so move the header into an >> >> easily-accessible location. >> > >> >> diff --git a/arch/arm/cpu/armv7/tegra2/ap20.c >> >> b/arch/arm/cpu/armv7/tegra2/ap20.c >> > >> >> -#include "ap20.h" >> >> #include <asm/io.h> >> >> #include <asm/arch/tegra2.h> >> >> +#include <asm/arch/ap20.h> >> > >> > BTW, why do we have separate tegra2.h and ap20.h? >> >> I'm not sure - was ap20 the old name? Tom do you know? For now we use >> ap20 as the interface to the AVP side, and where we start up the A9. > AP20 is the name of one classification/sku/bin/type of Tegra20 chip - > Application Processor, IIRC. Usually AP20 and T20 are used interchangeably. > The history of ap20.h is messy - it came from our Embedded group originally > and was ported to U-Boot by stripping out all the NV-proprietary-API cruft, > changing CamelCase var/func names, to U-Boot-compliant code, etc. At this > point, it might be able to be merged w/tegra2.h, but tegra2.h is more general > to the entire chip and its periphs, and ap20.h is more specific to the CPU(s) > and AVP/CPU init. But I won't object to a merger.
Thanks for that. Perhaps we should rename it to avp or cpu_init. Something to think about. > > Tom >> >> Regards, >> Simon > -- > nvpublic Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
