Mike Frysinger wrote: > this is less bloat: > int board_saveenv(void) __attribute__((weak, alias("saveenv"))); > > int do_env_save(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) > { > printf("Saving Environment to %s...\n", env_name_spec); > return board_saveenv() ? 1 : 0; > }
I don't think this can work: cmd_nvedit.c:599:5: error: 'board_saveenv' aliased to undefined symbol 'saveenv' cmd_nvedit.c:599:5: error: 'board_saveenv' aliased to undefined symbol 'saveenv' make[1]: *** [/home/b04825/git/u-boot.0/1022/common/cmd_nvedit.o] Error 1 It looks like weak functions can't be in another source file? If I change it to this, then it works: static int __saveenv(void) { return saveenv(); } int board_saveenv(void) __attribute__((weak, alias("__saveenv"))); int do_env_save(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) { printf("Saving Environment to %s...\n", env_name_spec); return board_saveenv() ? 1 : 0; } -- Timur Tabi Linux kernel developer at Freescale _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot